Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amazonq): Fix edge cases of context command updates #6686

Merged
merged 6 commits into from
Feb 27, 2025
Merged

fix(amazonq): Fix edge cases of context command updates #6686

merged 6 commits into from
Feb 27, 2025
+44 −32

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented Feb 26, 2025 •
edited
Loading

Problem

  1. If user create a file using the File>New File buttons, the onCreateFile listener does not capture it.
Screenshot 2025-02-26 at 2 46 31 PM
  1. Renaming file or folders is not listened and updated.

Solution

  1. Listen to new files created by File>New File buttons
  2. Listen to renaming file or folders
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested review from a team as code owners February 26, 2025 21:29
@github-actions GitHub Actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jpinkney-aws jpinkney-aws merged commit 36caa76 into aws:feature/falcon Feb 27, 2025
15 of 17 checks passed
justinmk3
justinmk3 reviewed Feb 27, 2025
View reviewed changes
packages/core/src/amazonq/lsp/lspClient.ts
// user created a new empty file using File -> New File
// these events will not be captured by vscode.workspace.onDidCreateFiles
// because it was created by File Explorer(Win) or Finder(MacOS)
// TODO: consider using a high performance fs watcher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? fs watchers have been a source of performance issues in the past. Please do not add more of them without careful consideration. (We already spawn tons of them.)

justinmk3
justinmk3 reviewed Feb 27, 2025
View reviewed changes
packages/core/src/amazonq/lsp/lspClient.ts
{ interval: 500, timeout: 5_000, truthy: true }
)
}
const onRemove = async (filePaths: string[]) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is nearly identical to the onAdd case above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk3 justinmk3 justinmk3 left review comments

@jpinkney-aws jpinkney-aws jpinkney-aws approved these changes

@avi-alpert avi-alpert avi-alpert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leigaol @justinmk3 @jpinkney-aws @avi-alpert